feat(tesseract): Custom granularities support #9400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9400 +/- ##
==========================================
- Coverage 83.72% 83.72% -0.01%
==========================================
Files 229 229
Lines 82614 82614
==========================================
- Hits 69172 69168 -4
- Misses 13442 13446 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KSDaemon
reviewed
Mar 28, 2025
| return this.resolveSymbolsCallDeps2(cubeName, sql); | ||
| const deps: any[] = []; | ||
| this.resolveSymbolsCall(sql, (name) => { | ||
| deps.push({ name, undefined }); |
Member
There was a problem hiding this comment.
What did you mean? It seems to be incorrect. what did you want to mark as undefined? You're pushing an object, not a tuple.
| self.date_range.clone() | ||
| } | ||
|
|
||
| pub fn get_range_for_time_seiories(&self) -> Result<Option<(String, String)>, CubeError> { |
Member
There was a problem hiding this comment.
Suggested change
| pub fn get_range_for_time_seiories(&self) -> Result<Option<(String, String)>, CubeError> { | |
| pub fn get_range_for_time_series(&self) -> Result<Option<(String, String)>, CubeError> { |
rust/cubesqlplanner/cubesqlplanner/src/planner/sql_evaluator/dependecy.rs
Outdated
Show resolved
Hide resolved
waralexrom
force-pushed
the
tesseract-fix-rolling-window-with-multiple-time-dimensions
branch
from
9f89296 to
424bdbd
Compare
waralexrom
force-pushed
the
tesseract-custom-granularities-support
branch
from
e0c5a44 to
a8476d9
Compare
KSDaemon
reviewed
Mar 28, 2025
| return this.resolveSymbolsCallDeps2(cubeName, sql); | ||
| const deps: any[] = []; | ||
| this.resolveSymbolsCall(sql, (name) => { | ||
| deps.push({ name, parent: undefined }); |
Member
There was a problem hiding this comment.
Just
Suggested change
| deps.push({ name, parent: undefined }); | |
| deps.push({ name }); |
KSDaemon
approved these changes
Mar 28, 2025
Member
KSDaemon
left a comment
KSDaemon
left a comment
There was a problem hiding this comment.
👍🏻 LGTM! Left one minor note :)
ovr
reviewed
Mar 28, 2025
rust/cubesqlplanner/cubesqlplanner/src/planner/time_dimension/date_time.rs
Outdated
Show resolved
Hide resolved
Base automatically changed from
tesseract-fix-rolling-window-with-multiple-time-dimensions
to
master
March 28, 2025 18:28
waralexrom
force-pushed
the
tesseract-custom-granularities-support
branch
from
af4571b to
c4f8b9c
Compare
marianore-muttdata
pushed a commit
to MuttData/cube
that referenced
this pull request
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Issue Reference this PR resolves
[For example #12]
Description of Changes Made (if issue reference is not provided)
[Description goes here]